It will settle, at some level, whether POTUS is acting for his own benefit.If something is not a legal requirement, I see no point in aquiescing to a demand that will settle nothing. And labeling what you want him to do "the right thing" doesn't make it so, it merely begs the question
Perhaps the other side of the issue should authoritatively get together and produce a list of demands, with the inducement that satisfying them would end all future questioning by politicians and the press about Trump's finances. That you know that's impossible to deliver should tell you why I wouldn't bother
I think anything that would "end all future questioning by politicians and the press" is a fundamentally bad deal to begin with. And, steps toward .... authoritarianism.